fix: Prevent ObjectDisposedException during CancellationTokenSource disposal - #28
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses issue SERVICES-4C, an
ObjectDisposedExceptionoccurring when aCancellationTokenSource(CTS) is disposed concurrently with itsCancelAftertimer firing.The root cause was a race condition in
GenOnlineService/Constants.cswithin thefinallyblock afterm_SockInternal.SendAsync. ACancellationTokenSourcewas created withCancelAfter(500ms)and then immediately disposed. IfSendAsynccompleted just as the 500ms timer was about to fire, the timer's callback execution could attempt to access the already-disposed CTS, leading to the exception.The fix involves calling
cts.CancelAfter(Timeout.InfiniteTimeSpan)beforects.Dispose(). This disarms the pending timer, ensuring that it cannot fire after the CTS has been disposed, thereby eliminating the race condition and preventing theObjectDisposedException.Fixes SERVICES-4C